feat(pass-extension): add autofill keyboard shortcut command by yuribodo · Pull Request #481 · ProtonMail/WebClients

yuribodo · 2026-03-29T16:40:38Z

Summary

Adds a keyboard shortcut to trigger autofill in the Proton Pass browser extension, as discussed and approved in #453.

Registers a new autofill command in Chrome and Firefox manifests with Ctrl+Shift+U as the default shortcut
Handles the command in the background script by sending an AUTOFILL_TRIGGER message to the active tab's content script
Content script finds the first detected login field and opens the autofill dropdown, reusing the existing inline dropdown flow

Closes #453

Changes

File	Change
`manifest-chrome.json`	Added `"autofill"` command entry
`manifest-firefox.json`	Added `"autofill"` command entry
`src/types/messages.ts`	Added `AUTOFILL_TRIGGER` to `WorkerMessageType` enum
`src/lib/extension/commands.ts`	Added async handler for the `"autofill"` command
`src/lib/extension/commands.spec.ts`	Added 4 unit tests for command handling
`src/app/content/services/autofill/autofill.service.ts`	Registered `AUTOFILL_TRIGGER` handler using `withContext` pattern

How it works

User presses Ctrl+Shift+U
browser.commands.onCommand fires in the background script
Background queries the active tab and sends AUTOFILL_TRIGGER via browser.tabs.sendMessage
Content script's FrameMessageBroker receives the message
Handler finds the first field with DropdownAction.AUTOFILL_LOGIN via formManager.getFields()
Opens the autofill dropdown on that field using inline.dropdown.toggle()
User selects credentials → normal autofill flow proceeds

If no login field is detected on the page, the shortcut is a no-op.

Design decisions

Default shortcut Ctrl+Shift+U: Chosen to avoid conflicts with existing commands (Ctrl+Shift+X for popup, Ctrl+Shift+L for larger window). The industry standard for autofill is Ctrl+Shift+L (used by Bitwarden and LastPass). If the team is open to it, reassigning Ctrl+Shift+L from open-larger-window to autofill in a follow-up would align with user expectations from competing password managers.

Dropdown approach (not direct autofill): Opens the dropdown instead of auto-filling the top match. This is safer, gives the user control when multiple credentials match, and reuses the existing dropdown infrastructure with minimal new code.

Safari excluded: Safari does not support the browser.commands API. The command listener is already gated by BUILD_TARGET !== 'safari' in worker/index.ts.

Test plan

Unit tests for handleExtensionCommand (4 tests passing):
- Opens larger window for open-larger-window command
- Sends AUTOFILL_TRIGGER to active tab for autofill command
- Does not send message when no active tab is found
- Does nothing for unknown commands
Manual: press Ctrl+Shift+U on a login page → dropdown opens on first login field
Manual: press Ctrl+Shift+U on a page with no login form → nothing happens
Manual: verify Ctrl+Shift+X and Ctrl+Shift+L still work as before
Manual: verify new shortcut appears in Settings → Shortcuts

i18n(weekly-mr:app): Upgrade translations from crowdin (2d51304). for webapps See merge request web/clients!25193

Add support for system groups See merge request web/clients!25054

Extracting reused withTimeout to package/meet/utils See merge request web/clients!25060

Disable auto-complete on chat See merge request web/clients!25115

Scopes usernames with bdi See merge request web/clients!25117

fix(account): remove access check in categories settings See merge request web/clients!25198

Do not scroll element in view when changing page See merge request web/clients!25197

Rework byoe access check See merge request web/clients!25202

[REALTIME-240] Homepage SDK - folder events See merge request web/clients!25110

i18n(weekly-mr:app): Upgrade translations from crowdin (53310fd). for webapps See merge request web/clients!25210

Fix upsell path See merge request web/clients!25217

Sheets: Fix issue with settings dialog menu item See merge request web/clients!25218

The Ctrl+Shift+U shortcut opens the dropdown with autofocused:false, so neither the page field nor the iframe receives keyboard focus. Expose requestFocus() on the dropdown that reuses the existing focus-lock bypass, and call it once the dropdown is visible so the suggestions can be reached from the keyboard.

…keys Wire useDropdownArrowNavigation + useHotkeys (bound to the iframe document) in the login view so the suggestions can be moved through with the arrow keys, selected with Enter, and dismissed with Escape. Highlight the focused item in the injected dropdown styles.

yuribodo · 2026-06-04T19:37:05Z

Hi @nguyenkims, I agree with your point having to reach for the mouse to pick a login kind of defeats the purpose of a keyboard shortcut. Based on that, I made some adjustments to the PR

Just like you said, once the dropdown is shown you can now select a login entirely from the keyboard, with the up/down arrow keys

I also rebased on the latest main so the diff is clean now. Let me know if you'd prefer different key bindings

nguyenkims · 2026-06-24T14:22:52Z

Thanks a lot for adapting the MR!

I think it'd be nice to show a message when there's no login form on the page. It can be a simple error message like "No login form is found"

If pass is locked, it'd be useful to show a message like "Please unlock pass" when the shortcut is pressed.

For the shortcut default, i think ctrl+shift+f might be a good candidate (F stands for Fill). This shortcut doesn't seem to be used by other browsers.

It'd be great to add this shortcut on the setting page here too

edvincandon · 2026-06-24T14:36:16Z

+    if (command === 'autofill') {
+        const [tab] = await browser.tabs.query({ active: true, currentWindow: true });
+        if (tab?.id != null) {
+            browser.tabs.sendMessage(tab.id, backgroundMessage({ type: WorkerMessageType.AUTOFILL_TRIGGER })).catch(noop);


We recently added support for autofilling iframe fields as well (will be released in 1.38.0). This trigger will end up only broadcasting to the top-frame. We could iterate through all frames (starting from the top-level one) until we have a match and early exit here. It would require WorkerMessageType.AUTOFILL_TRIGGER's responses to carry a result.

edvincandon · 2026-06-24T14:37:23Z

+import { WorkerMessageType } from 'proton-pass-extension/types/messages';
+
+jest.mock('@proton/pass/lib/globals/browser', () => ({
+    tabs: {


You can use (and/or augment) the applications/pass-extension/src/__mocks__/webextension-polyfill/index.ts global mocks here

edvincandon · 2026-06-24T14:43:58Z

+        /** Only arm the field action-trap when the anchor field is the active element — i.e. the
+         * focus-recovery scenario. The shortcut flow opens the dropdown without focusing the field,
+         * so arming it there would needlessly suppress the field's normal autofocus dropdown. */
+        if (anchor.current?.type === 'field' && isActiveElement(anchor.current.field.element)) {


For your use-case : could we rather drill a boolean flag down onWillFocus & onFocusRequest rather than relying on an active element check here ? The reason being : by-passing focus-traps is time-sensitive and the document.activeElement may be stale when onWillFocus triggers from an actual dropdown initiated focus request (but not through your new exposed handle).

D-Bao · 2026-06-24T16:06:02Z

+    const onAutofillTrigger: FrameMessageHandler<WorkerMessageType.AUTOFILL_TRIGGER> = withContext(async (ctx) => {
+        const dropdown = ctx?.service.inline.dropdown;
+        const fields = ctx?.service.formManager.getFields();
+        const loginField = fields?.find((field) => field.action?.type === DropdownAction.AUTOFILL_LOGIN);
+
+        if (!dropdown || !loginField) return;
+
+        dropdown.toggle({
+            type: 'field',
+            action: DropdownAction.AUTOFILL_LOGIN,
+            autofocused: false,
+            autofilled: loginField.autofilled !== null,
+            field: loginField,
+        });
+
+        /** Keyboard-only flow: once the dropdown is visible, move keyboard focus into it
+         * so the user can navigate the login suggestions with the arrow keys and select
+         * one with Enter — without touching the mouse. Unlike the focus-on-field flow,
+         * the shortcut opens the dropdown with `autofocused: false`, so nothing has moved
+         * focus into the iframe yet. */
+        await waitUntil(() => dropdown.getState().then(({ visible }) => visible), 25, DROPDOWN_AUTOFOCUS_TIMEOUT)


There is a small type error when running yarn check-types inside applications/pass-extension, this shouldn't be async:

Suggested change

const onAutofillTrigger: FrameMessageHandler<WorkerMessageType.AUTOFILL_TRIGGER> = withContext(async (ctx) => {

const dropdown = ctx?.service.inline.dropdown;

const fields = ctx?.service.formManager.getFields();

const loginField = fields?.find((field) => field.action?.type === DropdownAction.AUTOFILL_LOGIN);

if (!dropdown || !loginField) return;

dropdown.toggle({

type: 'field',

action: DropdownAction.AUTOFILL_LOGIN,

autofocused: false,

autofilled: loginField.autofilled !== null,

field: loginField,

});

/** Keyboard-only flow: once the dropdown is visible, move keyboard focus into it

* so the user can navigate the login suggestions with the arrow keys and select

* one with Enter — without touching the mouse. Unlike the focus-on-field flow,

* the shortcut opens the dropdown with `autofocused: false`, so nothing has moved

* focus into the iframe yet. */

await waitUntil(() => dropdown.getState().then(({ visible }) => visible), 25, DROPDOWN_AUTOFOCUS_TIMEOUT)

const onAutofillTrigger: FrameMessageHandler<WorkerMessageType.AUTOFILL_TRIGGER> = withContext((ctx) => {

const dropdown = ctx?.service.inline.dropdown;

const fields = ctx?.service.formManager.getFields();

const loginField = fields?.find((field) => field.action?.type === DropdownAction.AUTOFILL_LOGIN);

if (!dropdown || !loginField) return;

dropdown.toggle({

type: 'field',

action: DropdownAction.AUTOFILL_LOGIN,

autofocused: false,

autofilled: loginField.autofilled !== null,

field: loginField,

});

/** Keyboard-only flow: once the dropdown is visible, move keyboard focus into it

* so the user can navigate the login suggestions with the arrow keys and select

* one with Enter — without touching the mouse. Unlike the focus-on-field flow,

* the shortcut opens the dropdown with `autofocused: false`, so nothing has moved

* focus into the iframe yet. */

void waitUntil(() => dropdown.getState().then(({ visible }) => visible), 25, DROPDOWN_AUTOFOCUS_TIMEOUT)

Note that my suggestion may be changed if you implement #481 (comment)

L10n bot and others added 30 commits May 28, 2026 09:37

i18n(meet): update translations from crowdin a839510627

7efb1b8

Merge branch 'translations_2026-05-28_050342_81cbca15' into 'main'

53310fd

i18n(weekly-mr:app): Upgrade translations from crowdin (2d51304). for webapps See merge request web/clients!25193

Add support for system groups

99ae628

Merge branch 'hide-system-groups' into 'main'

124f1b4

Add support for system groups See merge request web/clients!25054

Extracting reused withTimeout to package/meet/utils

0ba6fef

Merge branch 'with-timeout' into 'main'

1de0126

Extracting reused withTimeout to package/meet/utils See merge request web/clients!25060

Disable auto-complete on chat

9318380

Merge branch 'MEET-1155' into 'main'

9999b9e

Disable auto-complete on chat See merge request web/clients!25115

Scopes usernames with bdi

c5dc394

Merge branch 'MEET-1156' into 'main'

cc33c97

Scopes usernames with bdi See merge request web/clients!25117

fix(account): remove access check in categories settings

49004d3

Merge branch 'fix/categories-lite-settings-acces' into 'main'

ae5abda

fix(account): remove access check in categories settings See merge request web/clients!25198

refac(mail): scope focusElement inside mail focus effect

919d09f

refactor(mail): inline single-use resetFocusID and saveNewState helpers

007973e

refac(mail): read data from Redux instead of props in useMailboxFocus

d2e12c8

Merge branch 'INWEB-611-prevent-scroll-on-page-chagne' into 'main'

8fcaf65

Do not scroll element in view when changing page See merge request web/clients!25197

Rework byoe access check

353b48e

Merge branch 'P1-497-rework-byoe-display-to-sub-users' into 'main'

411116a

Rework byoe access check See merge request web/clients!25202

[REALTIME-240] Homepage SDK - folder events

e944e8a

Merge branch 'feature/REALTIME-240-folder-events' into 'main'

cd82872

[REALTIME-240] Homepage SDK - folder events See merge request web/clients!25110

i18n(mail): update translations from crowdin e3aa4b2785

9eeb331

i18n(verify): update translations from crowdin 20e885f6c9

ab4deac

i18n(pass-web): update translations from crowdin e923d7fed1

0faa5e9

Merge branch 'translations_2026-05-28_101351_8b7a4b3d' into 'main'

1d92991

i18n(weekly-mr:app): Upgrade translations from crowdin (53310fd). for webapps See merge request web/clients!25210

Fix upsell path

430910e

Merge branch 'fix/dashboard-path' into 'main'

ebb9c0b

Fix upsell path See merge request web/clients!25217

Sheets: Fix issue with settings dialog menu item

6c35cef

Merge branch 'sheets-fix-settings-dialog-button' into 'main'

c77de53

Sheets: Fix issue with settings dialog menu item See merge request web/clients!25218

perfs(mail): skip immutable and serialize check in tests

58078da

test(mail): clear jest fake timers in mail tests

13f0160

mmso force-pushed the main branch 2 times, most recently from 115579e to b6fd253 Compare June 3, 2026 16:16

yuribodo added 2 commits June 3, 2026 23:38

yuribodo force-pushed the feat/autofill-keyboard-shortcut branch from b9a9fb0 to d639fe2 Compare June 4, 2026 02:47

mmso force-pushed the main branch 8 times, most recently from 25168a8 to 97c88ca Compare June 12, 2026 09:51

edvincandon reviewed Jun 24, 2026

View reviewed changes

D-Bao reviewed Jun 24, 2026

View reviewed changes

mmso force-pushed the main branch 9 times, most recently from 6e496e5 to bfa5069 Compare July 31, 2026 08:17

mmso force-pushed the main branch 2 times, most recently from 896ff9e to 06694ac Compare August 5, 2026 16:22

Navigation Menu

Uh oh!

feat(pass-extension): add autofill keyboard shortcut command - #481

feat(pass-extension): add autofill keyboard shortcut command#481
yuribodo wants to merge 1666 commits into
ProtonMail:mainfrom
yuribodo:feat/autofill-keyboard-shortcut

yuribodo commented Mar 29, 2026 •

edited

Loading

Uh oh!

yuribodo commented Jun 4, 2026

Uh oh!

nguyenkims commented Jun 24, 2026

Uh oh!

edvincandon Jun 24, 2026

Uh oh!

edvincandon Jun 24, 2026 •

edited

Loading

Uh oh!

edvincandon Jun 24, 2026 •

edited

Loading

Uh oh!

D-Bao Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

yuribodo commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

How it works

Design decisions

Test plan

Uh oh!

yuribodo commented Jun 4, 2026

Uh oh!

nguyenkims commented Jun 24, 2026

Uh oh!

edvincandon Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

edvincandon Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edvincandon Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

D-Bao Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

yuribodo commented Mar 29, 2026 •

edited

Loading

edvincandon Jun 24, 2026 •

edited

Loading

edvincandon Jun 24, 2026 •

edited

Loading